search

RocketChat / helm-charts

Repository for RocketChat helm charts
37 stars 67 forks source link

There is an error in your readme file #4

Closed skadefro closed 3 years ago

skadefro commented 3 years ago

The url for the chart is https://rocketchat.github.io/helm-charts/charts/ so in the readme it should say

$ helm repo add rocketchat https://rocketchat.github.io/helm-charts/charts/

also, it's good practice to publish a link to your values.yaml so we know what settings we have to work with

skadefro commented 3 years ago

And another correction, there is a fatal error in your Chart.yaml file you are missing the condition on the dependency to mongodb, so it will install mongodb even when your dont want to! it should be:

dependencies:
- name: mongodb
  repository: https://charts.bitnami.com/bitnami
  version: 7.x.x
  condition: mongodb.enabled
sampaiodiego commented 3 years ago

thanks for the tips @skadefro .. a PR would be really appreciated.

pinging @LuluGO and @geekgonecrazy just in case.

skadefro commented 3 years ago

Sure, I can do that, might first be tomorrow.

skadefro commented 3 years ago

Closing. I ended up publishing my own ( you can find it https://github.com/open-rpa/helm-charts/tree/main/charts/rocketchat ) and use it as helm install rocket openiap/rocketchat -n=rocket --values=.\config\rocket.yaml