RocketChat / helm-charts

Repository for RocketChat helm charts
37 stars 67 forks source link

[Fix] Use prometheusScraping.port variable and honor prometheusScraping.enabled #46

Closed sporqist closed 2 years ago

sporqist commented 2 years ago

Problem: Setting a custom value for prometheusScraping.port in values.yaml has no effect, as the variable isn't actually being used in the port definition in chat-deployment.yaml.

Solution: Add the variable to port definitions in chat-deployment.yaml and fence it so the port only gets defined when prometheusScraping.enabled is true.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

sporqist commented 2 years ago

I accidentally made all the changes in my forks main branch. Gonna move this to a separate branch and open another pr.

sporqist commented 2 years ago

#47