RocketChat / helm-charts

Repository for RocketChat helm charts
37 stars 67 forks source link

[Fix] Use prometheusScraping variables #47

Closed sporqist closed 2 years ago

sporqist commented 2 years ago

Problem: Setting a custom value for prometheusScraping.port in values.yaml has no effect, as the variable isn't actually being used in the port definition in chat-deployment.yaml.

Solution: Add the variable to port definitions in chat-deployment.yaml and fence it so the port only gets defined when prometheusScraping.enabled is true.

Also add a metrics port to the service, so prometheus can scrape it.

r0zbot commented 2 years ago

Thanks for the fix!