search

RocketChat / helm-charts

Repository for RocketChat helm charts
37 stars 67 forks source link

MongoDB engine unknown #51

Closed MatthiasHertel closed 1 year ago

MatthiasHertel commented 2 years ago

Hi,

i have a question, why is the MongoDB Engine unknown ?

i used the chart internal mongodb version.

image

Matthias

r0zbot commented 2 years ago

I'm not sure, but we just use the Bitnami mongodb helm chart as a dependency. Maybe you could ask there directly?

debdutdeb commented 2 years ago

Yup this is something I fixed recently in docker. I'll take a look how to include that in our helm chart

debdutdeb commented 2 years ago

@prppedro did you fix this? :eyes:

debdutdeb commented 2 years ago

Doesn't look like fixed on master 😬

prppedro commented 2 years ago

The fix was adequate, but proven impractical for our Helm implementation, hence we removed the fix.

debdutdeb commented 2 years ago

Any discussions you can point me to?

r0zbot commented 2 years ago

We've mostly discussed this in DM's, maybe @prppedro can explain a bit better, but from what I remember the issue with that PR arose when there is more than one helm install on the same namespace, or when trying to upgrade.

And the problem is a bit trickier to fix as we can't template values to match the deployment-name (and thus make it unique).

The CI caught this, but only after it was already merged into master too.

debdutdeb commented 1 year ago

Fixed in https://github.com/RocketChat/helm-charts/commit/4b6751c9469628ad4f889ff6ca3de9b633ca8b1d For reference: https://github.com/RocketChat/helm-charts/blob/efed6b2a729b8dba8ab35a92f5fbc37009f825b7/rocketchat/templates/mongodb-init-configmap.yaml#L2-L3