RocketChat / helm-charts

Repository for RocketChat helm charts
36 stars 67 forks source link

warning: cannot overwrite table with non table for rocketchat.ingress.tls (map[]) #66

Open wethinkagile opened 2 years ago

wethinkagile commented 2 years ago
coalesce.go:220: warning: cannot overwrite table with non table for rocketchat.ingress.tls (map[])
coalesce.go:220: warning: cannot overwrite table with non table for rocketchat.ingress.tls (map[])

Then:

Rocket.Chat will be available at the URL:
- http://

What is this?

This is my ingress part:

ingress:
  enabled: true
  pathType: Prefix
  ingressClassName: "kong"
  annotations:
    kubernetes.io/tls-acme: "true"
    cert-manager.io/cluster-issuer: letsencrypt-prod
    ingress.kubernetes.io/force-ssl-redirect: "true"
  path: /
  tls:
    - secretName: mydomain-rocketchat-tls
      hosts:
        - sub.mydomain.de

So in source, this part seems problematic:

{{- if $ingress.tls }}
  tls:
  {{- range $ingress.tls }}
    - hosts:
      {{- range .hosts }}
        - {{ . }}
      {{- end }}
      {{- if .secretName }}
      secretName: {{ .secretName }}
      {{- end }}
  {{- end }}
{{- end }}
  rules:
  - 
  {{- if .Values.host }}
    host: {{ .Values.host }}
  {{- end }}
johntwyman commented 1 year ago

It seems there's been a regression since the fix was merged. The definition for the tls variable is a dict rather than an array in the head of the master branch (as of 2023-06-07).

Has there been a rebase or similar? Because git blame shows tls: {} as being committed in 2021, before this issue was opened and the fix merged.