search

RocketChat / helm-charts

Repository for RocketChat helm charts
37 stars 67 forks source link

Add support for tolerations in all deployments and pods #95

Closed LaloLoop closed 6 months ago

LaloLoop commented 1 year ago

Closes In the Helm chart toleration missed #89

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

AlexGidman commented 7 months ago

@LaloLoop were there any issues with having this merged? This is something we're looking at for an enterprise deployment, we really don't want to have to fork the helm chart!

LaloLoop commented 7 months ago

Hi @AlexGidman , we have yet to get any feedback from the RocketChat team. Hello @debdutdeb, @geekgonecrazy . Sorry to tag you directly, I'm adding you as I found your usernames in recent PR reviews/merges. Any chance of getting a review here? Thanks!

debdutdeb commented 7 months ago

Could this key be per-deployment and not common for all?

Maybe there could be a global key that is common, then per-deployment to override each. I see the value in not having to repeat for all deployments.

AlexGidman commented 7 months ago

Could this key be per-deployment and not common for all?

Maybe there could be a global key that is common, then per-deployment to override each. I see the value in not having to repeat for all deployments.

I'll admit that I don't know all situations where tolerations may be applicable; in our case, the ability to apply tolerations 'globally' is a lot cleaner and sufficient for our purposes.