search

RocketChat / helm-charts

Repository for RocketChat helm charts
36 stars 67 forks source link

Added nodeSelector to deployments #98

Closed atropos112 closed 1 year ago

atropos112 commented 1 year ago

I am in need of node selector, because my cluster has nodes with amd64 as well as arm64 architectures and rocketchat doesn't have arm64 images so was crashlooping.

I can't see a single reason not to add this to main line and let others use this when they please, hence the PR. The issue made here: https://github.com/RocketChat/helm-charts/issues/99

Note the mongodb also has to have nodeSelector set but its already present in that helm chat.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

ChrisJBurns commented 1 year ago

Can confirm we need nodeSelector functionality also. I can close https://github.com/RocketChat/helm-charts/issues/97 when this PR is merged

ChrisJBurns commented 1 year ago

@atropos112 I can't see the values.yaml file being updated?

atropos112 commented 1 year ago

Thanks @ChrisJBurns , I added the nodeSelector bit to values. Was testing by changing value.yaml file and once I felt everything worked i "git restored" the values.yaml forgetting there was a change there, thanks ! Added nodeSelector to values.yaml now.

TheBoboNL commented 1 year ago

You missed the hook-verify-mongodb-version.yaml file.