search

RocketChat / hubot-rocketchat-boilerplate

An example Hubot demonstrating usage of the Rocket.Chat adaptor.
MIT License
36 stars 32 forks source link

Updated dockerfile to support latest version #5

Closed edzillion closed 5 years ago

edzillion commented 6 years ago

I am a still getting up to speed with Docker so take that into account when reviewing, but everything seems to work.

I decided to skip the previous entry point but I left the line in so it can be uncommented by those still using coffeescript. 

# bin/hubot -n $BOT_NAME -a rocketchat
CMD npm run local

Also I had to change package.json to pull down hubot-rocketchat as it wasn't being found locally:

"hubot-rocketchat": "2.0.0"

Also there is a problem with the adapter as there is no support in the latest hubot-rocketchat for the RC environment variables. I have made a fairly hacky fix and will post a PR in a sec.

edzillion commented 6 years ago

FYI

https://github.com/RocketChat/hubot-rocketchat/pull/291

JSzaszvari commented 6 years ago

Hi @edzillion There's currently a DockerFile refresh, rather refactor of the whole container going on in this PR - https://github.com/RocketChat/hubot-rocketchat/pull/289

We don't want to push the latest version of the adapter into the latest docker tag just yet as there is some further testing that needs to be done.

Once we figure out any outstanding compatibility issues we'll merge the changes into this repo as well for the Docker Image (still figuring out which repo we should have the DockerImage in.

Ref: https://github.com/RocketChat/hubot-rocketchat/issues/286 https://github.com/RocketChat/hubot-rocketchat/pull/289

edzillion commented 6 years ago

Sure, no worries.