Now that rocketchat uses node v8.9.3 .. this should also use the upgraded node.

RocketChat / hubot-rocketchat

Rocket.Chat Hubot adapter

MIT License

575 stars 227 forks source link

Now that rocketchat uses node v8.9.3 .. this should also use the upgraded node. #258

Open vikaskedia opened 6 years ago

vikaskedia commented 6 years ago

Ref: https://github.com/RocketChat/Docker.Base.Image/blob/c04ac6c3a6add3850cd15eb5e9f38a894cd7a151/Dockerfile#L23

geekgonecrazy commented 6 years ago

I believe with the conversion to js this might be possible

Wirone commented 4 years ago

I'm currently porting our Internal Hubot scripts to external Hubot instance and I get SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode, most probably because of very old node version (4.8.3) in rocketchat/hubot-rocketchat image...

Is it possible to bump Node version?

EDIT: finally I used cusdeb/hubot-rocketchat:2.0-amd64 as image for building our bot.

Wirone commented 4 years ago

Still not updated :tired_face: I totally forgot about this issue and I'v commented commit that introduced info about v2.x.x with Node 8 and Hubot v3. Hope it can be resolved...