search

RocketCommunicationsInc / astro-components

Other
24 stars 8 forks source link

Astro 1557 update slider km #157

Closed micahjones13 closed 3 years ago

micahjones13 commented 3 years ago

Updated the slider color vars and values to be in line with current abstract and KM standards. Jira Link Dark theme changes:

  1. --sliderThumbBackgroundColor: var(--backgroundColor); from --sliderThumbBackgroundColor: var(--primaryDark);
  2. --sliderThumbBorderColor: var(--primary); from --sliderThumbBorderColor: var(--inputBackground);
  3. --sliderTrackBackgroundColor: var(--primary); from --sliderTrackBackgroundColor: var(--secondaryText);
  4. --sliderSelectedThumbBorderColor: var(--primaryLight); from --sliderSelectedThumbBorderColor: var(--primaryLight);
  5. Upped --sliderThumbBorderSize to 2px instead of 1px, as per abstract

Light theme:

  1. --sliderThumbBackgroundColor: var(--backgroundColor); from --sliderThumbBackgroundColor: var(--primaryDark);
  2. --sliderThumbBorderColor: var(--primary); from --sliderThumbBorderColor: var(--inputBackground);
  3. --sliderTrackBackgroundColor: var(--primary); from --sliderTrackBackgroundColor: var(--inputBackground);
  4. Upped --sliderThumbBorderSize to 2px instead of 1px, as per abstract

The vars for hover values were not changed, I didn't see any slider hover files in abstract. If I'm just blind and didn't see them let me know. The massive file size is thanks to prettier.

amalyah commented 3 years ago

Ah I see what happened. You can use the Pressed state in Abstract for Hover. This brings up some need for better naming or at least commenting functions in the design files. We will work on that in the future. @avillaindesire do you agree with using the Pressed state for the hover state as well?

avillaindesire commented 3 years ago

Ah I see what happened. You can use the Pressed state in Abstract for Hover. This brings up some need for better naming or at least commenting functions in the design files. We will work on that in the future. @avillaindesire do you agree with using the Pressed state for the hover state as well?

Yep, we can use the pressed state for hover. In the future, we may want to explore a different state for hover since you can select any point on the track to move the thumb there.