search

RocketCommunicationsInc / astro-components

Other
24 stars 8 forks source link

Astro 1559 km radio button update #158

Closed NicDominguez closed 3 years ago

NicDominguez commented 3 years ago

Updates radio button dark-theme, light-theme, and core scss for KM updates. JIRA Ticket

Dark Theme Changes: --controlBorderColor: var(--primary) >>> var(--colorSecondaryDarken2) --controlSelectedBorderColor: var(--primary) >>> var(--colorSecondaryDarken2);

Light Theme Changes: --controlBorderColor: var(--primary) >>> var(--colorPrimaryLighten2)

Core Changes:

.rux-radio-button input[type="radio"]:checked + label::before {
    border-color: var(--controlSelectedOutlineBorderColor) >>> var(--controlSelectedBorderColor);;
}
markacianfrani commented 3 years ago

should this also be affecting the styles of checkbox and switch?

NicDominguez commented 3 years ago

should this also be affecting the styles of checkbox and switch?

Yes, they share the same global variables and all components have been are in the process of being updated to the new values just haven't been merge yet.