RocketCommunicationsInc / astro-components

Other
24 stars 8 forks source link

Astro 1568 km pop up update #159

Closed NicDominguez closed 3 years ago

NicDominguez commented 3 years ago

Updates pop up component dark-theme, light-theme, and core scss for KM updates. JIRA Ticket

Dark Theme Changes: --popupMenuBackgroundColor: var(--inputBackground) >>> var(--backgroundColor); --popupMenuBorderColor: var(--primary) >>> var(--primaryDarker); --popupMenuTextColor: var(--primaryElementText) >>> var(--primary); --popupCaretBackgroundColor: var(--primary) >>> var(--primaryDarker); --popupMenuItemBackgroundColor: var(--primary) >>> var(--backgroundColor); --popupMenuItemHoverBackgroundColor: var(--primaryLight) >>> rgba(28, 63, 94, 0.3); ^ unable to set an alpha value on a custom variable and have the scss compile correctly, if you know a way to do this please let me know. --popupMenuItemHoverTextColor: var(--primaryElementText) >>> var(--primaryLight); --popupMenuItemSeperatorBorderColor: var(--primaryElementText) >>> var(--primaryDarker);

Light Theme Changes: --popupMenuBackgroundColor: var(--inputBackground) >>> var(--backgroundColor); --popupMenuBorderColor: var(--primary) >>> var(--colorPrimaryLighten2); --popupMenuTextColor: var(--defaultText) >>> var(--primary); --popupCaretBackgroundColor: var(--primary) >>> var(--colorPrimaryLighten2); --popupMenuItemBackgroundColor: var(--primary) >>> var(--backgroundColor); --popupMenuItemHoverBackgroundColor: var(--primaryLight) >>> rgba(28, 63, 94, 0.3); see note in dark theme changes --popupMenuItemHoverTextColor: vary(--primaryElementText) >>> var(--primaryLight); --popupMenuItemSeperatorBorderColor: var(--primaryElementText) >>> var(--primaryDarker);

amalyah commented 3 years ago

Quick note: In the branch description I think you meant to say that you're making changes to pop ups in the first sentence instead of radio buttons.