RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.
https://astrouxds.com
Other
115 stars 25 forks source link

fix(rux-checkbox): fix bug where the invisible <input> component was interfering with certain layouts #1008

Closed kiley-mitti closed 1 year ago

kiley-mitti commented 1 year ago

Brief Description

The element in the Shadow DOM of rux-checkbox is opacity:0 and position: absolute. However, since no parent element was position:relative, the was just kind of going wherever it felt like on the page and wreaking havoc. I added position:relative to the label element which contains both our custom input and the actual in order to contain it.

JIRA Link

ASTRO-5148

Related Issue

General Notes

Motivation and Context

Minor bug fix to address some layout abnormalities when using many rue-checkboxes, as you might in a table of events.

Issues and Limitations

Types of changes

Checklist

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 010ff21723288ed14582e9da156f38eab2d21c24

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for astro-preview ready!

Name Link
Latest commit 010ff21723288ed14582e9da156f38eab2d21c24
Latest deploy log https://app.netlify.com/sites/astro-preview/deploys/63bf0003ad99d800080fb640
Deploy Preview https://deploy-preview-1008--astro-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.