test(dialog): added waitForChanges to prevent dialog flake

RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.

https://astrouxds.com

Other

115 stars 25 forks source link

test(dialog): added waitForChanges to prevent dialog flake #1050

Closed micahjones13 closed 1 year ago

micahjones13 commented 1 year ago

Brief Description

adds page.waitForChanges to two dialog tests that would sometimes fail.

JIRA Link

https://rocketcom.atlassian.net/browse/ASTRO-5329

Related Issue

General Notes

Motivation and Context

Issues and Limitations

Types of changes

[ ] Bug fix
[ ] New feature
[ ] Breaking change

Checklist

[ ] This PR adds or removes a Storybook story.
[ ] I have added tests to cover my changes.
[ ] Regressions are passing and/or failures are documented
[ ] Changes have been checked in evergreen browsers

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 379e665db77372adc3c04c59e68cb9b8680e21fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for astro-stencil ready!

Name	Link
Latest commit	379e665db77372adc3c04c59e68cb9b8680e21fe
Latest deploy log	https://app.netlify.com/sites/astro-stencil/deploys/63d2d123e434560008e413dd
Deploy Preview	https://deploy-preview-1050--astro-stencil.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.