RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.
https://astrouxds.com
Other
115 stars 25 forks source link

rux-select disabled property not working #1120

Closed gsp-lm closed 1 year ago

gsp-lm commented 1 year ago

Describe the bug After upgrading to 7.9.2, setting [disabled]="true" on a rux-select element does not disable the rux-select element

To Reproduce Steps to reproduce the behavior:

  1. Add a rux-select element with disabled set

Current behavior The rux-select element is not disabled

Expected behavior The rux-select element should be disabled

Environment (please complete the following information):

micahjones13 commented 1 year ago

Hey @gsp-lm

I'm having trouble reproducing this issue. I've set up a codesandbox that renders a disabled rux-select menu, and a toggle to disable/enable a select menu. Feel free to change the code to add some more context.

gsp-lm commented 1 year ago

The issue seems to be only happening when the rux-select is part of a form, but I can't seem to replicate it in the sandbox. I'll update it if I figure out exactly what combination of things caused this issue, but our solution for now is just removing the rux-select from the form group.

micahjones13 commented 1 year ago

Huh, interesting. What version of astrouxds/angular where you upgrading from?

gsp-lm commented 1 year ago

7.0.2

micahjones13 commented 1 year ago

Going to close this issue as stale, please re-open or reach out if this problem comes up again and can be reproduced!