RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.
https://astrouxds.com
Other
108 stars 25 forks source link

fix(rux-segmented-button) programmatically select segments #1135

Closed kiley-mitti closed 1 year ago

kiley-mitti commented 1 year ago

Brief Description

Segmented button had an issue when trying to programmatically select a segment using rux-segmented-button's 'selected' attribute. It would select any item that was not initially selected.

JIRA Link

ASTRO-6212

Related Issue

General Notes

I put a listener on 'selected' and updated the input check when it changes.

Motivation and Context

This use case is likely small but it was making the component act strangely with the controls in Storybook and Playground.

Issues and Limitations

Types of changes

Checklist

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 7599f235b8f4b690c6f7ecb576c98bc454609a00

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for astro-stencil ready!

Name Link
Latest commit 7599f235b8f4b690c6f7ecb576c98bc454609a00
Latest deploy log https://app.netlify.com/sites/astro-stencil/deploys/6464dd17d1e24d0007cdd9f7
Deploy Preview https://deploy-preview-1135--astro-stencil.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 1 year ago

Deploy Preview for astro-preview ready!

Name Link
Latest commit 7599f235b8f4b690c6f7ecb576c98bc454609a00
Latest deploy log https://app.netlify.com/sites/astro-preview/deploys/6464dd18870298000877deed
Deploy Preview https://deploy-preview-1135--astro-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.