fix(rux-input) password show/hide button

RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.

https://astrouxds.com

Other

113 stars 25 forks source link

fix(rux-input) password show/hide button #1141

Closed kiley-mitti closed 1 year ago

kiley-mitti commented 1 year ago

Brief Description

When you programatically change run-ionput's type from 'password' to anything else, the show/hide password toggle would remain on the input.

This PR fixes that.

JIRA Link

ASTRO-6230

Related Issue

General Notes

Motivation and Context

Probably a small use case, but it will make it work properly on our playground.

Issues and Limitations

Types of changes

[x] Bug fix
[ ] New feature
[ ] Breaking change

Checklist

[ ] This PR adds or removes a Storybook story.
[x] I have added tests to cover my changes.
[x] Regressions are passing and/or failures are documented
[x] Changes have been checked in evergreen browsers

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 3a4cd3b6592906a49531d0ec97fe85f746270995

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for astro-preview ready!

Name	Link
Latest commit	3a4cd3b6592906a49531d0ec97fe85f746270995
Latest deploy log	https://app.netlify.com/sites/astro-preview/deploys/6466726ab81d690008899dc2
Deploy Preview	https://deploy-preview-1141--astro-preview.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.