feat(select): borderless variant

RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.

https://astrouxds.com

Other

108 stars 25 forks source link

feat(select): borderless variant #1142

Closed micahjones13 closed 1 year ago

micahjones13 commented 1 year ago

Brief Description

Adds a new borderless prop to rux-select. This styles the select menu to be a more "inline" variant.

JIRA Link

https://rocketcom.atlassian.net/browse/ASTRO-6193

Related Issue

General Notes

This came out of building the datepicker/calendar component. Calendar uses this type of select menu, but it doesn't yet exist in the design system.

Motivation and Context

Create variant needed for calendar.

Issues and Limitations

Types of changes

[ ] Bug fix
[x] New feature
[ ] Breaking change

Checklist

[ ] This PR adds or removes a Storybook story.
[ ] I have added tests to cover my changes.
[ ] Regressions are passing and/or failures are documented
[ ] Changes have been checked in evergreen browsers

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 5d90addbb875e63dbe96eff4ede0b7cab6a53301

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for astro-stencil ready!

Name	Link
Latest commit	5d90addbb875e63dbe96eff4ede0b7cab6a53301
Latest deploy log	https://app.netlify.com/sites/astro-stencil/deploys/64aeaf02a86bd60008713d74
Deploy Preview	https://deploy-preview-1142--astro-stencil.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.