fix(progress): respect max when value increases

RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.

https://astrouxds.com

Other

113 stars 25 forks source link

fix(progress): respect max when value increases #1144

Closed micahjones13 closed 1 year ago

micahjones13 commented 1 year ago

Brief Description

Changes progress to respect max instead of changing max to equal value when value gets beyond max. This seems to be legacy functionality and isn't justified anymore. Was brought up in the demo day and was declared a bug. This fix swaps the (backwards) functionality of max changing to equal value with value instead changing to equal max if value is being incremented past the max prop.

Updates a test.

JIRA Link

https://rocketcom.atlassian.net/browse/ASTRO-6244

Related Issue

General Notes

Motivation and Context

Noticed by user. Makes progress act as you would expect

Issues and Limitations

Types of changes

[x] Bug fix
[ ] New feature
[ ] Breaking change

Checklist

[ ] This PR adds or removes a Storybook story.
[x] I have added tests to cover my changes.
[ ] Regressions are passing and/or failures are documented
[ ] Changes have been checked in evergreen browsers

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 0adc5ce5e2d839e381c70148a2751b5664fbdc65

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for astro-stencil ready!

Name	Link
Latest commit	0adc5ce5e2d839e381c70148a2751b5664fbdc65
Latest deploy log	https://app.netlify.com/sites/astro-stencil/deploys/646e6991cab4010008794d14
Deploy Preview	https://deploy-preview-1144--astro-stencil.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.