RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.
https://astrouxds.com
Other
108 stars 25 forks source link

fix(rux-log) search input updates when filter is updated programatically #1152

Closed kiley-mitti closed 1 year ago

kiley-mitti commented 1 year ago

Brief Description

Added a watch decorator to filter and had search update when filter changed and the two fall out of sync.

JIRA Link

ASTRO-1842

Related Issue

General Notes

Pretty easy fix though I am wondering if I should add an event for the filter change...

Motivation and Context

Low impact issue but in the case that a dev is trying to filter from external js, the filter string didn't populate into the search input (though the items did still filter properly). This makes sure that the filter and the search stay in sync.

Issues and Limitations

Types of changes

Checklist

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: c800f8674e7349c5418ac5696e034c7c46cf6776

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for astro-stencil ready!

Name Link
Latest commit c800f8674e7349c5418ac5696e034c7c46cf6776
Latest deploy log https://app.netlify.com/sites/astro-stencil/deploys/647e0536df78b10008176bd4
Deploy Preview https://deploy-preview-1152--astro-stencil.netlify.app/components/rux-log/test
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 1 year ago

Deploy Preview for astro-preview ready!

Name Link
Latest commit c800f8674e7349c5418ac5696e034c7c46cf6776
Latest deploy log https://app.netlify.com/sites/astro-preview/deploys/647e0536fa48f90008f27151
Deploy Preview https://deploy-preview-1152--astro-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.