RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.
https://astrouxds.com
Other
108 stars 25 forks source link

fix(rux-log) bring row height into alignment with figma #1153

Closed kiley-mitti closed 1 year ago

kiley-mitti commented 1 year ago

Brief Description

Changed the row-height in run-log to be --spacing-8 - 1px (32px - bottom border) so that it would be aligned with figma design and our 4px design grid.

JIRA Link

ASTRO-6157

Related Issue

General Notes

Motivation and Context

Figma designs updated because rux-log was not previously following our 4px grid system as rows were only 30px tall.

Issues and Limitations

I marked this as a minor change since it changes some dimensions but it may just be patch. Up to you Mark. :)

Types of changes

Checklist

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 0389ac234797a32c903a8ea6af4f3fbded9247e0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for astro-stencil ready!

Name Link
Latest commit 0389ac234797a32c903a8ea6af4f3fbded9247e0
Latest deploy log https://app.netlify.com/sites/astro-stencil/deploys/647e163caa2e27000991f807
Deploy Preview https://deploy-preview-1153--astro-stencil.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 1 year ago

Deploy Preview for astro-preview ready!

Name Link
Latest commit 0389ac234797a32c903a8ea6af4f3fbded9247e0
Latest deploy log https://app.netlify.com/sites/astro-preview/deploys/647e163c10a4190008319e76
Deploy Preview https://deploy-preview-1153--astro-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

kiley-mitti commented 1 year ago

/update snapshots

kiley-mitti commented 1 year ago

/update-snapshots