RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.
https://astrouxds.com
Other
113 stars 25 forks source link

stencil@v3 #1168

Closed markacianfrani closed 1 year ago

markacianfrani commented 1 year ago

Brief Description

Upgrades to Stencil v3. Exports all the types from root package so now users can do things like

import { RuxSliderCustomEvent, Status } from "@astrouxds/react"

or

import { RuxSliderCustomEvent, Status } from "@astrouxds/astro-web-components"

instead of having to import from

import {
  RuxSegmentedButtonCustomEvent,
} from "@rocketmark/astro-web-components";

JIRA Link

ASTRO-4933

Related Issue

General Notes

Motivation and Context

external feedback

Issues and Limitations

we need an entirely new way to document all of our types. Storybook won't cut it out of the box. Our inconsistent naming conventions will also be brought out to light now. As a QOL in next release, we should standardize some of these type names, if anything to minimize namespace collisions in the future if the root is going to export everything.

Types of changes

Checklist

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: be9e37625197697ae7fd4ec89f279e832bd91f19

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for astro-stencil ready!

Name Link
Latest commit be9e37625197697ae7fd4ec89f279e832bd91f19
Latest deploy log https://app.netlify.com/sites/astro-stencil/deploys/649d7c9da26d300008f986c3
Deploy Preview https://deploy-preview-1168--astro-stencil.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 year ago

Deploy Preview for astro-preview ready!

Name Link
Latest commit be9e37625197697ae7fd4ec89f279e832bd91f19
Latest deploy log https://app.netlify.com/sites/astro-preview/deploys/649d7c9d66703e00088aee79
Deploy Preview https://deploy-preview-1168--astro-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.