Closed kiley-mitti closed 1 year ago
changeset-bot[bot]
commented
1 year ago Latest commit: 3d3b39825507b2ae4c9adc3251e5073fcfcf264f
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
netlify[bot]
commented
1 year ago | Name | Link |
|---|---|
| Latest commit | 3d3b39825507b2ae4c9adc3251e5073fcfcf264f |
| Latest deploy log | https://app.netlify.com/sites/astro-stencil/deploys/649d99ed4cf5a3000818a76e |
| Deploy Preview | https://deploy-preview-1169--astro-stencil.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
netlify[bot]
commented
1 year ago | Name | Link |
|---|---|
| Latest commit | 3d3b39825507b2ae4c9adc3251e5073fcfcf264f |
| Latest deploy log | https://app.netlify.com/sites/astro-preview/deploys/649d99ed3775740008d7c208 |
| Deploy Preview | https://deploy-preview-1169--astro-preview.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Brief Description
This adds a size prop to the monitoring icon which gets passed down to the rux-icon inside.
JIRA Link
No ticket, just a suggestion.
Related Issue
976
General Notes
Motivation and Context
This has been a requested feature over time which we have put off because Design said we would run into legibility issues. Then in the Collab a couple of weeks ago, Jean said something about needing to resize the monitoring icon to fit in a shrunk down version of the GSB and design agreed that that customization seemed necessary.
So.. taking that and running with it, ALL this change does is allow you to change the size of the icon. It does not change the way the monitoring icon component works in any other way.
Issues and Limitations
This means that if someone sets the icon to be too large (over 4.5rem) or too small, it looks odd and they would have to further modify some styles. This can be fixed by modifying the way that rux-monitoring-icon is styled but it would be a breaking change.
Types of changes
Checklist