RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.
https://astrouxds.com
Other
108 stars 25 forks source link

(fix)tooltip: add watcher to placement prop #1170

Closed FMorrison87 closed 1 year ago

FMorrison87 commented 1 year ago

Brief Description

This PR fixes an issue where the tooltip would not respond if the placement prop was updated. A watcher was added to placement that forces a rerender, so if the prop changes, the tooltip placement will change as well. This PR also adds reflection to the placement prop and a test to cover that reflection.

JIRA Link

ASTRO-6065

Related Issue

General Notes

Motivation and Context

A developer should be able to imperatively change the placement prop on a tooltip and have it update in real time.

Issues and Limitations

Types of changes

Checklist

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 316481188d71690a2d8d18491be1e9c1fd77cb69

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for astro-preview ready!

Name Link
Latest commit 316481188d71690a2d8d18491be1e9c1fd77cb69
Latest deploy log https://app.netlify.com/sites/astro-preview/deploys/649d9b5e9af3810008a227f0
Deploy Preview https://deploy-preview-1170--astro-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 year ago

Deploy Preview for astro-stencil ready!

Name Link
Latest commit 316481188d71690a2d8d18491be1e9c1fd77cb69
Latest deploy log https://app.netlify.com/sites/astro-stencil/deploys/649d9b5e7301ea000877ec50
Deploy Preview https://deploy-preview-1170--astro-stencil.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.