docs(popup) storybook fix

RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.

https://astrouxds.com

Other

108 stars 25 forks source link

docs(popup) storybook fix #1173

Closed kiley-mitti closed 1 year ago

kiley-mitti commented 1 year ago

Brief Description

Noticed that the placement prop wasn't hooked up in storybook so I made a quick fix. I thought the problem was the same as tooltip but it appears not to be the case.

JIRA Link

No ticket, noticed this on accident when checking out a different PR.

Related Issue

General Notes

Motivation and Context

Issues and Limitations

Types of changes

[ ] Bug fix
[ ] New feature
[ ] Breaking change

Checklist

[ ] This PR adds or removes a Storybook story.
[ ] I have added tests to cover my changes.
[ ] Regressions are passing and/or failures are documented
[ ] Changes have been checked in evergreen browsers

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 040e28ebd3efcd4ea1b7a01ac6ed37300f29f484

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for astro-preview ready!

Name	Link
Latest commit	040e28ebd3efcd4ea1b7a01ac6ed37300f29f484
Latest deploy log	https://app.netlify.com/sites/astro-preview/deploys/649f0e500a7a6c00074176b9
Deploy Preview	https://deploy-preview-1173--astro-preview.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.