Changed rux-select to use box-shadow rather than border

RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.

https://astrouxds.com

Other

113 stars 25 forks source link

Changed rux-select to use box-shadow rather than border #1191

Closed nortonprojects closed 1 year ago

nortonprojects commented 1 year ago

Brief Description

rux-input uses box-shadow, not border, which gives it a height of 36px by default. rux-select uses the opposite, which gives it a height of 38px by default. This makes aligning a rux-select and rux-input extremely frustrating.

This PR just changes rux-select to be consistent with rux-input, making the height the same and alignment trivial.

Types of changes

[X] Bug fix
[ ] New feature
[X??] Breaking change

Checklist

[ ] This PR adds or removes a Storybook story.
[ ] I have added tests to cover my changes.
[ ] Regressions are passing and/or failures are documented
[ ] Changes have been checked in evergreen browsers

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 9d2b8c86cf8479ea6a2b6ac745cb630168e52885

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for astro-preview ready!

Name	Link
Latest commit	9d2b8c86cf8479ea6a2b6ac745cb630168e52885
Latest deploy log	https://app.netlify.com/sites/astro-preview/deploys/64bea72db88bff00083df942
Deploy Preview	https://deploy-preview-1191--astro-preview.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.