Closed kiley-mitti closed 1 year ago
changeset-bot[bot]
commented
1 year ago Latest commit: c08b18da764de65bd2f7aba82b9b5bdc9c6bc8e5
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
netlify[bot]
commented
1 year ago | Name | Link |
|---|---|
| Latest commit | c08b18da764de65bd2f7aba82b9b5bdc9c6bc8e5 |
| Latest deploy log | https://app.netlify.com/sites/astro-preview/deploys/64c7fd6073d233000887a66e |
| Deploy Preview | https://deploy-preview-1198--astro-preview.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
netlify[bot]
commented
1 year ago | Name | Link |
|---|---|
| Latest commit | c08b18da764de65bd2f7aba82b9b5bdc9c6bc8e5 |
| Latest deploy log | https://app.netlify.com/sites/astro-stencil/deploys/64c7fd605518d20008d417be |
| Deploy Preview | https://deploy-preview-1198--astro-stencil.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Brief Description
Fixed the dropdown arrow so that it changes color based on light/dark theme.
JIRA Link
Astro-5888
Related Issue
General Notes
Motivation and Context
the dropdown arrow was not passing contrast accessibility in light mode.
Issues and Limitations
This is deceptively challenging because the arrow here is being generated as an svg background image so it can't take on our normal token variables. masking doesn't work because there are other background linear-gradients and such associated with the look of this. Can't put the dropdown arrow in an ::after psuedoclass because
Need to test cherry picking to make sure that it at least has a fallback.
Types of changes
Checklist