Km.6762 rux tabs onclick fix

RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.

https://astrouxds.com

Other

108 stars 25 forks source link

Km.6762 rux tabs onclick fix #1215

Closed kiley-mitti closed 1 year ago

kiley-mitti commented 1 year ago

Brief Description

Fixed an error in rux-tabs where if a tab was not clicked then it would throw an error.

JIRA Link

ASTRO-6762

Related Issue

General Notes

Motivation and Context

Its not a huge thing, just prevents the tabs from throwing errors in testing.

Issues and Limitations

Types of changes

[x] Bug fix
[ ] New feature
[ ] Breaking change

Checklist

[ ] This PR adds or removes a Storybook story.
[ ] I have added tests to cover my changes.
[x] Regressions are passing and/or failures are documented
[x] Changes have been checked in evergreen browsers

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: ee3ba5c8a6e6991dc0a737b256bb88b209165866

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for astro-stencil ready!

Name	Link
Latest commit	ee3ba5c8a6e6991dc0a737b256bb88b209165866
Latest deploy log	https://app.netlify.com/sites/astro-stencil/deploys/64dd0c3d5578250008cd0a15
Deploy Preview	https://deploy-preview-1215--astro-stencil.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.