search

RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.
https://astrouxds.com
Other
108 stars 25 forks source link

fix(rux-tooltip)tooltip is a different size when trigger is a block level element vs inline #1217

Closed kiley-mitti closed 1 year ago

kiley-mitti commented 1 year ago

Brief Description

I suspect that this was because there was an invisible in the component. I'm not sure why it was there so I'm hesitant to call this a fix without more testing.. but removing it and rearranging the code did seem to fix this specific issue. I'm putting this in draft so that Micah can have a chance to mess with it too.

JIRA Link

ASTRO-6764

Related Issue

Brought to our attention by this issue: #1216 (Thank you!)

General Notes

This does break the VRTs for tooltips but I think that's actually ok. They are all using

so they had the extra space built in.

Motivation and Context

Makes tooltip behave in a more intuitive way when faces with interior elements.

Issues and Limitations

Types of changes

  • [x] Bug fix
  • [ ] New feature
  • [ ] Breaking change

Checklist

  • [ ] This PR adds or removes a Storybook story.
  • [ ] I have added tests to cover my changes.
  • [x] Regressions are passing and/or failures are documented
  • [x] Changes have been checked in evergreen browsers
changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: e274d12754fb90feccd369debcf7f20aef3dd4fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for astro-preview ready!

Name Link
Latest commit e274d12754fb90feccd369debcf7f20aef3dd4fe
Latest deploy log https://app.netlify.com/sites/astro-preview/deploys/64de4748d2299a0008d7284e
Deploy Preview https://deploy-preview-1217--astro-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 year ago

Deploy Preview for astro-stencil ready!

Name Link
Latest commit e274d12754fb90feccd369debcf7f20aef3dd4fe
Latest deploy log https://app.netlify.com/sites/astro-stencil/deploys/64de474883e29400085e288d
Deploy Preview https://deploy-preview-1217--astro-stencil.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.