feat(dialog): toggleOpen, openDialog, closeDialog methods

RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.

https://astrouxds.com

Other

108 stars 25 forks source link

feat(dialog): toggleOpen, openDialog, closeDialog methods #1224

Closed micahjones13 closed 1 year ago

micahjones13 commented 1 year ago

Brief Description

This adds a public toggleOpen method to rux-dialog that makes the dialog easier to open and close.

JIRA Link

https://rocketcom.atlassian.net/browse/ASTRO-6841

Related Issue

General Notes

Motivation and Context

On FDS we were having a problem where the open prop on dialog would get out of sync, and you had to listen to the closed and opened events in order to toggle the open prop correctly, which can be cumbersome and unintuitive.

Issues and Limitations

Types of changes

[ ] Bug fix
[x] New feature
[ ] Breaking change

Checklist

[ ] This PR adds or removes a Storybook story.
[x] I have added tests to cover my changes.
[ ] Regressions are passing and/or failures are documented
[ ] Changes have been checked in evergreen browsers

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 1e93e47eb8c740180269ca20d68329c61962db8d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for astro-stencil ready!

Name	Link
Latest commit	1e93e47eb8c740180269ca20d68329c61962db8d
Latest deploy log	https://app.netlify.com/sites/astro-stencil/deploys/65032f669328a9000808787d
Deploy Preview	https://deploy-preview-1224--astro-stencil.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.