Closed micahjones13 closed 10 months ago
Latest commit: d5c021759127876db59570dbbd653266b8954cc1
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Name | Link |
---|---|
Latest commit | d5c021759127876db59570dbbd653266b8954cc1 |
Latest deploy log | https://app.netlify.com/sites/astro-preview/deploys/65394472a31406000a0b4026 |
Deploy Preview | https://deploy-preview-1249--astro-preview.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Name | Link |
---|---|
Latest commit | d5c021759127876db59570dbbd653266b8954cc1 |
Latest deploy log | https://app.netlify.com/sites/astro-stencil/deploys/653944724bfebb00086928e0 |
Deploy Preview | https://deploy-preview-1249--astro-stencil.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Brief Description
This PR adds a reflect to the value prop of rux-select, as well as an initValue function that runs on connected callback. This function selects a the first 'rux-option' as the value if a value is not already defined.
I ran into an issue using FormData in a vanilla setting where select menu wouldn't have a value if you didn't interact with it. This could mean that form submissions could be incorrect if the dev used a select menu without a 'select an option...' option.
JIRA Link
Related Issue
General Notes
Motivation and Context
Issues and Limitations
Types of changes
Checklist