Km.6882 add keyboard control tooltip

RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.

https://astrouxds.com

Other

108 stars 25 forks source link

Km.6882 add keyboard control tooltip #1269

Closed kiley-mitti closed 9 months ago

kiley-mitti commented 9 months ago

Brief Description

Added an escape key listener that will close a tooltip if the tooltip trigger is either hovered or focused. If it is neither the escape key won't act on it.

JIRA Link

ASTRO-6882

Related Issue

General Notes

Motivation and Context

Cory (from Shoelace) mentioned that tooltips should have ability to close without moving the mouse or unfocusing. Seemed like a good idea.

Issues and Limitations

Make sure this is the functionality we want. I could remove the if statements in the listener and have all tooltips close whenever escape is pressed. That would also be valid. This is just more specific.

Types of changes

[ ] Bug fix
[x] New feature
[ ] Breaking change

Checklist

[ ] This PR adds or removes a Storybook story.
[x] I have added tests to cover my changes.
[x] Regressions are passing and/or failures are documented
[x] Changes have been checked in evergreen browsers

changeset-bot[bot] commented 9 months ago

🦋 Changeset detected

Latest commit: 7673c750e818badc245bc179beb082e7068bffef

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 9 months ago

Deploy Preview for astro-stencil ready!

Name	Link
Latest commit	7673c750e818badc245bc179beb082e7068bffef
Latest deploy log	https://app.netlify.com/sites/astro-stencil/deploys/656a3affac343700083674c1
Deploy Preview	https://deploy-preview-1269--astro-stencil.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.