Open kiley-mitti opened 10 months ago
Latest commit: 8395b0aef3b7c2d93499155d6e2a727e8d91aa3c
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Name | Link |
---|---|
Latest commit | 8395b0aef3b7c2d93499155d6e2a727e8d91aa3c |
Latest deploy log | https://app.netlify.com/sites/astro-preview/deploys/65ae9477f15b9f00083f9fef |
Deploy Preview | https://deploy-preview-1274--astro-preview.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Name | Link |
---|---|
Latest commit | 8395b0aef3b7c2d93499155d6e2a727e8d91aa3c |
Latest deploy log | https://app.netlify.com/sites/astro-stencil/deploys/65ae94778ecc110008c6daf9 |
Deploy Preview | https://deploy-preview-1274--astro-stencil.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Brief Description
--WIP --
This is a proof of concept for a new Astro Component for forces 24hour/12hour time input. It uses iMaskJs for masking.
The component is basically complete with just review and bug reports to work through, however, this PR also needs cleaning up and storybook additions before committing.
Update 1/22 - removed the 12hour masking functionality in favor of
type="time"
when 24h is not chosenTODO:
JIRA Link
R2C2-119
Related Issue
General Notes
Motivation and Context
This exploration of new components was undertaken because
<rux-input type="time">
is not as flexible as it could be regarding time input. There have been several requests from members of the current project for a component capable of forcing 24h time input.Issues and Limitations
There are still a couple of bugs I'd like to sort out at this time:
include-seconds
/ changingtimeformat
after first render will not actually change the input masking. This should be handled.Types of changes
Checklist