Closed kiley-mitti closed 9 months ago
changeset-bot[bot]
commented
9 months ago Latest commit: 48f30136534dd9b95d3b79facb5ddc462cddb46d
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
netlify[bot]
commented
9 months ago | Name | Link |
|---|---|
| Latest commit | 48f30136534dd9b95d3b79facb5ddc462cddb46d |
| Latest deploy log | https://app.netlify.com/sites/astro-stencil/deploys/65b92f63ab88150008534d35 |
| Deploy Preview | https://deploy-preview-1281--astro-stencil.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
netlify[bot]
commented
9 months ago | Name | Link |
|---|---|
| Latest commit | 48f30136534dd9b95d3b79facb5ddc462cddb46d |
| Latest deploy log | https://app.netlify.com/sites/astro-preview/deploys/65b92f6389b6a300089b5188 |
| Deploy Preview | https://deploy-preview-1281--astro-preview.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Brief Description
This fixes an attribute error in the console log if popup doesn't have a trigger.
JIRA Link
6883
Related Issue
General Notes
Motivation and Context
I saw an instance in a recent project where the popup was being used without a trigger and one of the functions was causing it to throw an error. I fixed that function.
Issues and Limitations
There are other errors that are thrown if you try to use popup without a slotted trigger.. but those would take more logic to solve.. might be worth future consideration though as technically you can programmatically show/hide a popup so it doesn't need a trigger for anything other than autopositioning.
I didn't work up a fix for that right now because it would likely be a major change.
Types of changes
Checklist