fix(timeline): playhead no longer throws error when undefined

RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.

https://astrouxds.com

Other

108 stars 25 forks source link

fix(timeline): playhead no longer throws error when undefined #1286

Closed micahjones13 closed 7 months ago

micahjones13 commented 7 months ago

Brief Description

Timeline was throwing a playhead range error even when setting the playhead to undefined. This adds a check before throwing the error to ensure that the playhead is assigned an actual date that could be incorrect.

JIRA Link

General Notes

Motivation and Context

Removes a console error that shouldn't be thrown.

Issues and Limitations

Types of changes

[x] Bug fix
[ ] New feature
[ ] Breaking change

Checklist

[ ] This PR adds or removes a Storybook story.
[ ] I have added tests to cover my changes.
[ ] Regressions are passing and/or failures are documented
[ ] Changes have been checked in evergreen browsers

changeset-bot[bot] commented 7 months ago

⚠️ No Changeset found

Latest commit: f58fc6d5e5b83255b0be4869b3191dd04e773cfc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 7 months ago

Deploy Preview for astro-stencil ready!

Name	Link
Latest commit	f58fc6d5e5b83255b0be4869b3191dd04e773cfc
Latest deploy log	https://app.netlify.com/sites/astro-stencil/deploys/65c149cca9a76e00082132a0
Deploy Preview	https://deploy-preview-1286--astro-stencil.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.