search

RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.
https://astrouxds.com
Other
113 stars 25 forks source link

rux-pop-up-menu does not render in <mat-drawer> #494

Closed tallen30 closed 2 years ago

tallen30 commented 2 years ago

When the rux-pop-up-menu is used in the mat-drawer (see https://material.angular.io/components/sidenav/api) it does not render properly. The menu looks like it tries to put it on the container but ends up somewhere else on the application.

micahjones13 commented 2 years ago

Hey @tallen30, just looking for some clarification on this issue - the pop up menu does not render within the mat-drawer that it's nested in? For example, I've made a sandbox testing it out using @astrouxds/angular@6.9.1 here. This is just using the angular mat drawer example on their docs site. The pop up is rendering within its container (at least in this example). Is this example helpful at all, or is it too off from your implementation? If so, is there anyway we could see a screenshot or a closer example in a separate code-sandbox?

VincentQDo commented 2 years ago

Please see this sandbox example here. When using with position="end". The pop up menu is trying to come up but is being put way off screen I think.

micahjones13 commented 2 years ago

Alright, I have some findings.

The pop up is not aligning itself relative to the mat-drawer and the trigger element, but instead relative to the entire page. This is placing it in really whacky places within mat-drawer. Good news is, in our upcoming 7.0 release this isn't an issue as we've re-worked pop-up. Here's a sandbox example of 7.0 working here.

Bad news is, the release date for 7.0 has been pushed backed, and we're still solidifying the new release date. I will reply here with that date when it becomes known.

In the meantime, you may be able to set the bounding of the pop-up menu yourself. It's pretty hacky, but here's an example sandbox if you're interested.

Sorry I don't have happier news, but a fix for this isn't on our roadmap in version 6 since it's solved in 7. I'll make sure to get back here with a 7.0 release date when I have one.

micahjones13 commented 2 years ago

7.0 release update: we're shooting for 9/29, one week from today. When 7 is released, these pop-up woes should be resolved. Thanks for your patience!