RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.
https://astrouxds.com
Other
115 stars 25 forks source link

feat(menu): allow for nested content in menu-items #841

Closed micahjones13 closed 2 years ago

micahjones13 commented 2 years ago

Brief Description

Updates rux-menu to handle nested content inside of rux-menu-items. Previously, if you had content that wasn't a rux-menu-item or nested content inside a menu-item, the events wouldn't fire like they should.

JIRA Link

Related Issue

https://github.com/RocketCommunicationsInc/astro/issues/839

General Notes

Motivation and Context

Allows for rux-menu to be used as a container, but also provides selection functionality when used with rux-menu-items.

Issues and Limitations

Types of changes

Checklist

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 958b1789696fe2b18aff307e16a9d3b50e6c411b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 2 years ago

Deploy Preview for astrouxds canceled.

Name Link
Latest commit 958b1789696fe2b18aff307e16a9d3b50e6c411b
Latest deploy log https://app.netlify.com/sites/astrouxds/deploys/6349893f83fd700008f8a61d
netlify[bot] commented 2 years ago

Deploy Preview for astro-preview ready!

Name Link
Latest commit 958b1789696fe2b18aff307e16a9d3b50e6c411b
Latest deploy log https://app.netlify.com/sites/astro-preview/deploys/6349893fe6f3690008b3db49
Deploy Preview https://deploy-preview-841--astro-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 2 years ago

Deploy Preview for blissful-hugle-92e0cf canceled.

Name Link
Latest commit 958b1789696fe2b18aff307e16a9d3b50e6c411b
Latest deploy log https://app.netlify.com/sites/blissful-hugle-92e0cf/deploys/6349893f18cd4600098499a2