RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.
https://astrouxds.com
Other
115 stars 25 forks source link

Chore: Remove jest unit tests and recreate missing coverage in Playwright #852

Closed FMorrison87 closed 2 years ago

FMorrison87 commented 2 years ago

Brief Description

This PR removes all of the Jest unit tests and their snapshots from each components 'test' directory. Some of the tests that were running in Jest did not exist in the new Playwright tests, so if there were gaps the tests were re-created in Playwright. A lot of components needed this gap filling before the Jest tests could be removed

JIRA Link

JIRA-4558

Related Issue

General Notes

Motivation and Context

This is one of the final pieces in the effort to move our testing suite completely into Playwright.

Issues and Limitations

Types of changes

Checklist

changeset-bot[bot] commented 2 years ago

⚠️ No Changeset found

Latest commit: cf50cae1037332ab386108fd55d1cd01968541de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 2 years ago

Deploy Preview for astrouxds ready!

Name Link
Latest commit cf50cae1037332ab386108fd55d1cd01968541de
Latest deploy log https://app.netlify.com/sites/astrouxds/deploys/6358139fd8b6f80009b613f7
Deploy Preview https://deploy-preview-852--astrouxds.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 2 years ago

Deploy Preview for blissful-hugle-92e0cf ready!

Name Link
Latest commit cf50cae1037332ab386108fd55d1cd01968541de
Latest deploy log https://app.netlify.com/sites/blissful-hugle-92e0cf/deploys/6358139f3299c80009132f85
Deploy Preview https://deploy-preview-852--blissful-hugle-92e0cf.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] commented 2 years ago

Deploy Preview for zealous-almeida-d12345 canceled.

Name Link
Latest commit d9c13ad23874417b3e7e61f0c5769785461b65f4
Latest deploy log https://app.netlify.com/sites/zealous-almeida-d12345/deploys/6352e0499b4350000aacbc7f
netlify[bot] commented 2 years ago

Deploy Preview for astro-preview ready!

Name Link
Latest commit cf50cae1037332ab386108fd55d1cd01968541de
Latest deploy log https://app.netlify.com/sites/astro-preview/deploys/6358139fe306cc0008012660
Deploy Preview https://deploy-preview-852--astro-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

markacianfrani commented 2 years ago

merged in separate PR