RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.
https://astrouxds.com
Other
115 stars 25 forks source link

refactor(input): removed autocomplete attr #881

Closed micahjones13 closed 2 years ago

micahjones13 commented 2 years ago

Brief Description

Removes the autocomplete attribute from rux-input due to it never taking effect. This isn't a breaking change because the attribute never worked in the first place; it only had the attribute in the shadow dom, but it wasn't functioning.

JIRA Link

https://rocketcom.atlassian.net/browse/ASTRO-4825

Related Issue

https://github.com/RocketCommunicationsInc/astro/issues/877 Issue was raised here. Fix for issue will be implemented at a later date.

General Notes

We are looking into fixes for this in future, but it has been deprioritized for now.

Motivation and Context

We don't want to provide an attribute that doesn't actually work.

Issues and Limitations

Types of changes

Checklist

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 3af0d003dcf93b11d80b0ca0a36d5040f02c9aa6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 2 years ago

Deploy Preview for astro-preview ready!

Name Link
Latest commit 3af0d003dcf93b11d80b0ca0a36d5040f02c9aa6
Latest deploy log https://app.netlify.com/sites/astro-preview/deploys/6362a1fa0e42520008ece012
Deploy Preview https://deploy-preview-881--astro-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.