test(ga): always run build as part of test setup

RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.

https://astrouxds.com

Other

115 stars 25 forks source link

test(ga): always run build as part of test setup #889

Closed micahjones13 closed 2 years ago

micahjones13 commented 2 years ago

Brief Description

Previously, our github action e2e tests would only run a stencil build if the package.json file had changed. This has been changed to run a build on every PR.

JIRA Link

https://rocketcom.atlassian.net/browse/ASTRO-4842

Related Issue

General Notes

Motivation and Context

GA will no longer pass if there are any build errors.

Issues and Limitations

Types of changes

[ ] Bug fix
[ ] New feature
[ ] Breaking change

Checklist

[ ] This PR adds or removes a Storybook story.
[ ] I have added tests to cover my changes.
[ ] Regressions are passing and/or failures are documented
[ ] Changes have been checked in evergreen browsers

changeset-bot[bot] commented 2 years ago

⚠️ No Changeset found

Latest commit: e726df409268727897968562a39293ce1b46669e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 2 years ago

Deploy Preview for astro-preview canceled.

Name	Link
Latest commit	e726df409268727897968562a39293ce1b46669e
Latest deploy log	https://app.netlify.com/sites/astro-preview/deploys/63640905c103ce000866a99f