RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.
https://astrouxds.com
Other
115 stars 25 forks source link

fix(rux-timeline): added left/right/both border to selected partial events #890

Closed kiley-mitti closed 2 years ago

kiley-mitti commented 2 years ago

Brief Description

Added borders to partial events even when selected. The borders are color/palette/neutral/1000 as they appear on the figma specs. This allows users to know that selected partial events are still partial events.

JIRA Link

ASTRO-4844

Related Issue

General Notes

Motivation and Context

Previously, when a partial timeline event was selected it would lose the dashed left/right border which indicated it as a partial event. Adding them back in a neutral color when selected, brings back the visual queue.

Issues and Limitations

Types of changes

Checklist

changeset-bot[bot] commented 2 years ago

⚠️ No Changeset found

Latest commit: c8b329ace6fe941e6576bd6e03278401ba608801

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 2 years ago

Deploy Preview for astro-preview ready!

Name Link
Latest commit c8b329ace6fe941e6576bd6e03278401ba608801
Latest deploy log https://app.netlify.com/sites/astro-preview/deploys/63656d3eb227b70009029b13
Deploy Preview https://deploy-preview-890--astro-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.