Mj 4867 pop up overflow

micahjones13 commented 2 years ago

Brief Description

The strategy prop on rux-pop-up was not being applied correctly. This now applies the correct position: to the pop-up. This fixes an issue where a pop-up inside a parent that had position: absolute; overflow: hidden would hide the pop-up.

JIRA Link

https://rocketcom.atlassian.net/browse/ASTRO-4867

Related Issue

General Notes

Motivation and Context

Pop-up was being hidden when the above conditions where being met.

Issues and Limitations

This still does not fix an issue where a transform on a parent will still hide some or all of the pop-up. This is due to transform creating it's own stacking context, and thus the pop-up gets rendered behind it.

Types of changes

[x] Bug fix
[ ] New feature
[ ] Breaking change

Checklist

[ ] This PR adds or removes a Storybook story.
[ ] I have added tests to cover my changes.
[ ] Regressions are passing and/or failures are documented
[x] Changes have been checked in evergreen browsers

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 1061418907be297f68c10eaf9039bc0bff193b5a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 2 years ago

Deploy Preview for astro-preview ready!

Name	Link
Latest commit	1061418907be297f68c10eaf9039bc0bff193b5a
Latest deploy log	https://app.netlify.com/sites/astro-preview/deploys/636d588b7bd4600008c577f3
Deploy Preview	https://deploy-preview-903--astro-preview.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

RocketCommunicationsInc / astro