RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.
https://astrouxds.com
Other
115 stars 25 forks source link

rux-monitoring-progress doesn't work inside a display: grid #909

Closed micahjones13 closed 2 years ago

micahjones13 commented 2 years ago

Describe the bug When using rux-monitoring-icon inside a display: flex, the styling of the component gets messed up.

To Reproduce Steps to reproduce the behavior:

  1. Create a display: grid
  2. Add a rux-monitoring-icon as an grid item
  3. See the top and bottom parts of rux-monitoring-icon split

Current behavior The styling breaks when put inside a display: grid

Expected behavior It shouldn't break inside a display grid

Screenshots Screen Shot 2022-11-11 at 1 46 16 PM

CodeSandbox https://codepen.io/micahjones/pen/poKyWQW

Environment (please complete the following information):

na

Additional context This can be fixed by adding width: fit-content to either the parent div or the component itself. The overall styling of rux-monitoring-progress needs looked at. Perhaps not having min/max width? https://github.com/RocketCommunicationsInc/astro/blob/main/packages/web-components/src/components/rux-monitoring-icon/rux-monitoring-icon.scss

micahjones13 commented 2 years ago

I'd also be interested to see if this issue applies to rux-monitoring-progress-icon as well, seeing as they are similar