(fix rux-status): Status has no default

RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.

https://astrouxds.com

Other

115 stars 25 forks source link

(fix rux-status): Status has no default #913

Closed FMorrison87 closed 2 years ago

FMorrison87 commented 2 years ago

Brief Description

If the user does not supply a 'status' to the component then nothing renders; it has no default state. This fix gives it a default state of 'normal' if nothing is passed in to status.

JIRA Link

ASTRO-4880

Related Issue

General Notes

Motivation and Context

Issues and Limitations

Types of changes

[x] Bug fix
[ ] New feature
[ ] Breaking change

Checklist

[ ] This PR adds or removes a Storybook story.
[ ] I have added tests to cover my changes.
[ ] Regressions are passing and/or failures are documented
[ ] Changes have been checked in evergreen browsers

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 2786f6dd327014f1092e9ec0f7e7713db1768740

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 2 years ago

Deploy Preview for astro-preview ready!

Name	Link
Latest commit	2786f6dd327014f1092e9ec0f7e7713db1768740
Latest deploy log	https://app.netlify.com/sites/astro-preview/deploys/6373ac4f63e2c000084cc36c
Deploy Preview	https://deploy-preview-913--astro-preview.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

micahjones13 commented 2 years ago

Could we give this a 'minor' changeset? A case could be made for patch, but I see this as more of a feature/enhancement than patch fix 🤷