Closed micahjones13 closed 1 year ago
Latest commit: 58cfe7e0339c91a38bd52ab6b71648bef985b56e
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Name | Link |
---|---|
Latest commit | 58cfe7e0339c91a38bd52ab6b71648bef985b56e |
Latest deploy log | https://app.netlify.com/sites/astro-preview/deploys/637e69f4538dbe000933ba6a |
Deploy Preview | https://deploy-preview-951--astro-preview.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Brief Description
Tests refactor, up until rux-notification. Refactors events to use new stencil-playwright, and removes 'it renders' tests.
One caveat to this is rux-menu. The event detail returns the node that's clicked, but the stencil-playwright method
toHaveReceivedEventDetail
only returns aref: <Node>
and you can't chain off of that. Therefore I just left that test how it was.JIRA Link
https://rocketcom.atlassian.net/browse/ASTRO-4895
Related Issue
General Notes
Motivation and Context
Issues and Limitations
Types of changes
Checklist