Closed jonathantneal closed 1 year ago
Latest commit: b734a17e567c37fde0e9b31e997e0422a57a365e
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Name | Link |
---|---|
Latest commit | b734a17e567c37fde0e9b31e997e0422a57a365e |
Latest deploy log | https://app.netlify.com/sites/astro-preview/deploys/6384e399f39b43000947b7b3 |
Brief Description
This updates the project to use built-in npm workspaces.
package.json#workspaces
, matching the configuration used inlerna.json
..npmrc
to workspace root to synchronize package manager preferences project-wide.lerna
in favor of workspaces.lerna.json
in favor ofpackage.json#workspaces
..github/workflows/publish.yml
per direction this file is no longer in use..husky/pre-push
per direction this file is no longer in use..scripts/release.js
per direction this file is no longer in use.CONTRIBUTING.md
.package-lock.json
files to reflect the new project configuration.jest
and@types/jest
dependencies to^27.5.1
, to resolve hoisting issues duringnpm run build
."typeRoots": ["node_modules/@types"]
to the reacttsconfig.json
, to resolve typing issues due to it using testing-library’sjsdom
. This is a newer version ofjsdom
that the rest of the project has not yet updated to.Motivation and Context
Our team discussed moving from lerna to built-in npm workspaces, due to various, increasing compatibility issues we encountered with lerna, and a perceived lack of upkeep by its new maintainers. We decided that using built-in npm workspaces resolves the compatibility issues and reduces the technical overhead required to work with this project.
Package Manager Preferences
These only reflect the default values, which allow overrides per operation.
package-lock.json
files, which is faster to read and smaller on disk. Lockfile v3 requires NPM v7+, and our repository has required NPM v8 for quite some time.JIRA Link
ASTRO-4899