RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.
https://astrouxds.com
Other
115 stars 25 forks source link

feat(clock): add static attribute #989

Closed markacianfrani closed 1 year ago

markacianfrani commented 1 year ago

Brief Description

adds a new static attribute to clock to prevent it from ticking

JIRA Link

ASTRO-5066

Related Issue

https://github.com/RocketCommunicationsInc/astro/discussions/936

Motivation and Context

Theres currently no way to just pass in your own time to Clock. date-in will start a clock from the time you provide, but you might not want this. Imagine syncing a Clock to Timeline where you might have the playhead control the time and can go back and forth.

Issues and Limitations

I would much rather have Clock be more primitive and composable, but after exploring that option, the scope is much larger and not something we can accommodate at this time.

Types of changes

Checklist

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 2d3c8e8bab5c7ef11504f777d4f166744a717280

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for astro-preview ready!

Name Link
Latest commit 2d3c8e8bab5c7ef11504f777d4f166744a717280
Latest deploy log https://app.netlify.com/sites/astro-preview/deploys/639c8093e047a100087d312d
Deploy Preview https://deploy-preview-989--astro-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.