Km 5055 progress bar percentage fix

RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.

https://astrouxds.com

Other

115 stars 25 forks source link

Km 5055 progress bar percentage fix #990

Closed kiley-mitti closed 1 year ago

kiley-mitti commented 1 year ago

Brief Description

Fixes to rux-progress that alter the way lower percentages on the progress bar appear.

JIRA Link

ASTRO-5055

Related Issue

#985

General Notes

Motivation and Context

rux-progress had odd visuals at low percentages. this change fixes that.

Issues and Limitations

This fix alters the way that borders on the progress bar are created, the active color border is now created with a box shadow while the inner 1px padding space is created by a border.

Types of changes

[x] Bug fix
[ ] New feature
[ ] Breaking change

Checklist

[ ] This PR adds or removes a Storybook story.
[ ] I have added tests to cover my changes.
[x] Regressions are passing and/or failures are documented
[x] Changes have been checked in evergreen browsers

changeset-bot[bot] commented 1 year ago

🦋 Changeset detected

Latest commit: 59ed9eaf5d3e5cce8b8da6efd7c184cfdc80a46d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

netlify[bot] commented 1 year ago

Deploy Preview for astro-preview ready!

Name	Link
Latest commit	59ed9eaf5d3e5cce8b8da6efd7c184cfdc80a46d
Latest deploy log	https://app.netlify.com/sites/astro-preview/deploys/63d7e3a4f0ccc00007ac4f5d
Deploy Preview	https://deploy-preview-990--astro-preview.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.