RocketCommunicationsInc / astro

Astro UXDS is a collection of guidelines, patterns and components for designing space-based user interface applications.
https://astrouxds.com
Other
115 stars 25 forks source link

add focus state for close button/keyboard control #994

Closed kiley-mitti closed 1 year ago

kiley-mitti commented 1 year ago

Brief Description

Rux-notification could not be focused since it did not have a tab index. Added that and keyboard controls and then our focus outline state.

JIRA Link

ASTRO-5078

Related Issue

General Notes

Motivation and Context

Focus state general tweaking

Issues and Limitations

We need to revisit some of our components that use overflow:hidden in any way. Sometimes this cuts off focus state which isn't great. In notification specifically we should revisit the idea that notifications should be truncated with no way to see the rest of the notification.

Types of changes

Checklist

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 0dbdddd09b5591e12d08eef36949dd0bc2a4791a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR