Fix Chat events for regular player chat.

RocketMod / Rocket.Unturned

Unturned 3 implementation of the RocketMod — .NET Game Server Plugin Framework

MIT License

85 stars 111 forks source link

Fix Chat events for regular player chat. #65

Closed cartman-2000 closed 6 years ago

cartman-2000 commented 6 years ago

This fixes the events for normal player chat, and adds the isRich to the OnPlayerChatted event. Plugins that use the OnPlayerChatted would need to update.

CLAassistant commented 6 years ago

All committers have signed the CLA.

Trojaner commented 6 years ago

The OnPlayerChatted "rich" parameter has not been adapted on purpose, to keep backwards compatibililty. The handler has been already fixed, as "tellChat" SteamCalls have been: https://github.com/RocketMod/Rocket.Unturned/commit/5f6671cb1dfbf5f29007caec49dac0efa7f07a61 https://github.com/RocketMod/Rocket.Unturned/commit/62cd8e8d6c780b5b46bba4ee1dbddaf72224f064

(This PR wouldn't solve the encoding bug on chat, as it does not fix tellChat missing parameter)

Trojaner commented 6 years ago

For OnPlayerChatted we either need to create a new, additional event - or break many plugins.

Yes, the parameter needs to be added sooner or later